Re: [PATCH 4/12] i386: define __pa_symbol()

[Franck Bui-Huu]

hi,

Sorry for the late feedback...

Vivek Goyal wrote:
> 
> On x86_64 we have to be careful with calculating the physical
> address of kernel symbols.  Both because of compiler odditities
> and because the symbols live in a different range of the virtual
> address space.
> 

[snip]

> +#define __pa_symbol(x)          \
> +	({unsigned long v;  \
> +	  asm("" : "=r" (v) : "0" (x)); \
> +	  __pa(v); })

Why not simply reusing RELOC_HIDE  like this ?

	#define __pa_symbol(x)	__pa(RELOC_HIDE(x,0))

thanks
		Franck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/