Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression

[Tim Chen]

On Tue, 2006-10-03 at 17:06 -0700, Jeremy Fitzhardinge wrote:

> How does the generated code change?  Doesn't evaluating the condition 
> multiple times have the potential to cause problems?
> 

I think if the condition changes between two evaluations, we do have a
problem with my fix.  I don't have a better idea to avoid using a local
variable to store the condition.  I think we should at least reverse the
WARN_ON/WARN_ON_ONCE patch if a better way cannot be found.

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/