Re: [patch 2/2]: acpi: add removable drive bay support

[Shem Multinymous]

Hi Kristen,

On 9/8/06, Kristen Carlson Accardi <kristen.c.accardi@xxxxxxxxx> wrote:

> +static void bay_notify(acpi_handle handle, u32 event, void *data)
[...]
> +       case ACPI_NOTIFY_EJECT_REQUEST:
[...]
> +               /* wouldn't it be a good idea to just call the
> +                * eject_device here if we were a SATA device?
> +                */

No, bay eject should go through userspace so that it gets a chance to
do cleanup (e.g., unmount filesystems) or to tell the user to abort
the eject (e.g., filesystems in use, or system running on bay battery
power).

And the driver of whatever is in the bay should be informed before
power is removed so it can do its own cleanup (e.g., spin down disk).
This can also be done by userspace.

So your current code is fine, and the comment should probably be
removed lest someone tries to follow it.

 Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/