Re: [PATCH] TIPC: fix printk warning

From: David Miller
Date: Tue Oct 03 2006 - 19:26:00 EST


From: Jeff Garzik <jeff@xxxxxxxxxx>
Date: Sun, 1 Oct 2006 12:24:13 -0400

> gcc spits out this warning:
>
> net/tipc/link.c: In function $,1rx(Blink_retransmit_failure$,1ry(B:
> net/tipc/link.c:1669: warning: cast from pointer to integer of different
> size
>
> More than a little bit ugly, storing integers in void*, but at least the
> code is correct, unlike some of the more crufty Linux kernel code found
> elsewhere.
>
> Rather than having two casts to massage the value into u32, it's easier
> just to have a single cast and use "%lu", since it's just a printk.
>
> Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx>

Applied, thanks Jeff.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/