Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

[Dmitry Torokhov]

On 10/2/06, Andrew Morton <akpm@xxxxxxxx> wrote:
> On Mon, 02 Oct 2006 17:21:09 +0100
> David Howells <dhowells@xxxxxxxxxx> wrote:
>
> > Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
> > of passing regs around manually through all ~1800 interrupt handlers in the
> > Linux kernel.
> >

Nice! I was wanting to do that for a long time...

> I think the change is good.  But I don't want to maintain this whopper
> out-of-tree for two months!  If we want to do this, we should just smash it
> in and grit our teeth.

Yes, lets drop it in while we still not reached rc1.

> > Some notes on the interrupt handling in the drivers:
> >
> >  (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
> >      the input_dev struct.

Good riddance... Athough I would not remove input_regs() just yet but
just redefine it to an empty inline and mark it as depreciated so we
won't break all out-of-tree input drivers right away. Removal of
input_regs() from in-tree drivers could be done by separate patch as
well, once main changes are in.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/