Re: [PATCH 2.6.18 V6] drivers: add lcd display support

From: Miguel Ojeda
Date: Sat Sep 30 2006 - 18:52:10 EST


Randy, I'm testing right now the V7 of the driver after fixing all
your mistakes found. Thank you for your deep work: the sharing of the
buffer was a very good point. Finally I allocated both 2 (the bigger
and the smaller one at the initialization).

In a few minutes I will send the V7 patch.

About "lcdisplay":

On 9/30/06, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
On Sat, 30 Sep 2006 23:36:44 +0200 Stefan Richter wrote:

> ...
> >> patching file drivers/lcddisplay/cfag12864b.c
> ...
>
> What does the D in LCD stand for? I suggest this is named
> drivers/lcdisplay/ instead.

Yes, someone else mentioned that too.
It does mean Display.
not a big deal to me in this age of acronyms.


Well, I can rename it, but there is a problem:

How should I write the name in other places?

I mean, for example, in Kconfig:

tristate "KS0108 LCD Controller"

if the ks0108 is a LCD controller, then

tristate "CFAG12864B LCD Display"

should be the right way to write it?

tristate "CFAG12864B LCDisplay"

seems so ugly to me. Is it? Remember, this applies for all the other
places in the documentation / source code / ...

IMHO it seems better as LCD Display. Yeah, drivers/lcdisplay/ would be
nice, but I don't think the same about other places:

LCD Controller.
LCDisplay??
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/