Re: [PATCH -mm 1/3] swsusp: Add ioctl for swap files support

From: Arnd Bergmann
Date: Sat Sep 30 2006 - 10:16:44 EST


Am Friday 29 September 2006 01:35 schrieb Rafael J. Wysocki:
> @@ -119,7 +119,18 @@ extern int snapshot_image_loaded(struct
>  #define SNAPSHOT_SET_SWAP_FILE         _IOW(SNAPSHOT_IOC_MAGIC, 10,
> unsigned int) #define
> SNAPSHOT_S2RAM                 _IO(SNAPSHOT_IOC_MAGIC, 11) #define
> SNAPSHOT_PMOPS                 _IOW(SNAPSHOT_IOC_MAGIC, 12, unsigned int)
> -#define SNAPSHOT_IOC_MAXNR     12
> +#define SNAPSHOT_SET_SWAP_AREA         _IOW(SNAPSHOT_IOC_MAGIC, 13, void *)
> +#define SNAPSHOT_IOC_MAXNR     13

Your definition looks wrong, '_IOW(SNAPSHOT_IOC_MAGIC, 13, void *)' means
your ioctl passes a pointer to a 'void *'.

You probably mean

#define SNAPSHOT_SET_SWAP_AREA _IOW(SNAPSHOT_IOC_MAGIC, 13, \
struct resume_swap_area)

Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/