Re: [PATCH] Fix up a multitude of ACPI compiler warnings on x86_64

From: Andrew Morton
Date: Fri Sep 29 2006 - 19:38:51 EST


On Fri, 29 Sep 2006 16:18:52 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:

> >
> > acpi-fix-printk-format-warnings.patch was submitted to the ACPI developers
> > on August 14 and on September 25 but remains unmerged.
>
> Len and I discussed that patch some. The question about it is:
> why does gcc report this at all? Is this a gcc problem or are
> we misreading it somehow?
>
> drivers/acpi/tables/tbget.c: In function 'acpi_tb_get_this_table':
> drivers/acpi/tables/tbget.c:326: warning: format '%X' expects type 'unsigned int', but argument 5 has type 'long unsigned int'
>
> drivers/acpi/tables/tbrsdt.c: In function 'acpi_tb_validate_rsdt':
> drivers/acpi/tables/tbrsdt.c:189: warning: format '%X' expects type 'unsigned int', but argument 5 has type 'long unsigned int'
>
> Why does it think that sizeof(struct X) is long unsigned int?
> (and only on 64-bit)

hm, strange. No warning at all on 32-bit.

Don't know. But the patch is correct.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/