Re: [PATCH] Fix up a multitude of ACPI compiler warnings on x86_64

From: Andrew Morton
Date: Fri Sep 29 2006 - 18:05:56 EST

On Fri, 29 Sep 2006 14:37:58 -0700
Martin Bligh <mbligh@xxxxxxxxxx> wrote:

> 32bit vs 64 bit issues. sizeof(sizeof) and sizeof(pointer) is variable,
> but we're trying to shove it into unsigned int or u32.
> ...
> - "RSDT/XSDT length (%X) is smaller than minimum (%X)",
> + "RSDT/XSDT length (%X) is smaller than minimum (%lX)",
> table_ptr->length,
> - sizeof(struct acpi_table_header)));
> + (unsigned long) sizeof(struct acpi_table_header)));

These two sizeof()s have already been fixed by Randy in -mm's

Randy's fix is the preferred one: sizeof() returns size_t and size_t's are
printed with %z - there's no need to use a typecast.

(Actually Randy used %Z which avoids the warning which old gcc emitted with
%z, but is old-fashioned. I'll switch that to %z).

acpi-fix-printk-format-warnings.patch was submitted to the ACPI developers
on August 14 and on September 25 but remains unmerged.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at