Re: [patch 2/2] libata: _SDD support

From: Valdis . Kletnieks
Date: Fri Sep 29 2006 - 13:56:37 EST

On Thu, 28 Sep 2006 11:30:43 PDT, Kristen Carlson Accardi said:
> _SDD (Set Device Data) is an ACPI method that is used to tell the
> firmware what the identify data is of the device that is attached to
> the port. It is an optional method, and it's ok for it to be missing.
> Because of this, we always return success from the routine that calls
> this method, even if the execution fails.

I'm OK on it returning success if the _SDD is missing entirely. And I see
where it's properly droppping a KERN_DEBUG-level printk if it misbehaves.
Whether it should continue on and return success anyhow, I'm not sure. Can one
of the ACPI wizards comment on that?

Attachment: pgp00000.pgp
Description: PGP signature