Re: [PATCH] IPv6/DCCP: Remove unused IPV6_PKTOPTIONS code

From: Arnaldo Carvalho de Melo
Date: Fri Sep 29 2006 - 10:41:03 EST


On 9/29/06, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
> Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv()

| otoh, it seems to me that opt_skb doesn't actually do anything and can be
| removed?
This is right, there is no code referencing opt_skb: compare with net/ipv6/tcp_ipv6.c.
Until someone has time to add the missing DCCP-specific code, it does seem better
to replace the dead part with a FIXME. This is done by the patch below, applies to
davem-net2.6 and has been tested to compile.

Thanks, I've been again sidetracked by Real Life(tm) but hopefully
tomorrow I'll go over all the DCCP pending patches backlog and get
them into tree to submit to Dave.

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/