[PATCH] NOMMU: Don't try and give NULL to fput()

From: David Howells
Date: Fri Sep 29 2006 - 05:35:37 EST


From: Gavin Lambert <gavinl@xxxxxxxxxxxxxx>

Don't try and give NULL to fput() in the error handling in do_mmap_pgoff() as
it'll cause an oops.

Signed-Off-By: David Howells <dhowells@xxxxxxxxxx>
---

mm/nommu.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/mm/nommu.c b/mm/nommu.c
index 5645406..3650195 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -948,7 +948,8 @@ #endif
up_write(&nommu_vma_sem);
kfree(vml);
if (vma) {
- fput(vma->vm_file);
+ if (vma->vm_file)
+ fput(vma->vm_file);
kfree(vma);
}
return ret;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/