Re: [NFS] [PATCH 009 of 11] knfsd: Allow max size of NFSd payloadto be configured.

From: Neil Brown
Date: Thu Sep 28 2006 - 22:00:30 EST


On Thursday September 28, hugh@xxxxxxxxxxx wrote:
> >
> > I'll submit a patch which uses
> > 12 - PAGE_SHIFT
> > in a little while.
>
> I haven't seen your context; but "12 - PAGE_SHIFT" sounds like a
> bad idea on all those architectures with PAGE_SHIFT 13 or more;
> you'll be on much safer ground working with "PAGE_SHIFT - 12".

Ahhh yes... of course. Thanks.

totalram <<= PAGE_SHIFT - 12;

Is what I want to convert a number of pages to 1/4096 the number of
bytes.

Thanks :-)

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/