[PATCH] Add flag __GFP_NOFAIL when allocating block

From: Zhang, Yanmin
Date: Thu Sep 28 2006 - 21:54:51 EST

From: Zhang, Yanmin <yanmin.zhang@xxxxxxxxx>

Function journal_write_metadata_buffer doesn't estimate the return
value of jbd_slab_alloc. If the allocation fails, later jbd_slab_free
or memcpy will cause kernel oops.

Add flag __GFP_NOFAIL when allocating block. The patch is against

Signed-off-by: Zhang Yanmin <yanmin.zhang@xxxxxxxxx>


--- linux-2.6.18_mm1/fs/jbd/journal.c 2006-09-29 07:19:49.000000000 -0600
+++ linux-2.6.18_mm1_fix/fs/jbd/journal.c 2006-09-30 03:01:38.000000000 -0600
@@ -329,7 +329,7 @@ repeat:
char *tmp;

- tmp = jbd_slab_alloc(bh_in->b_size, GFP_NOFS);
+ tmp = jbd_slab_alloc(bh_in->b_size, GFP_NOFS|__GFP_NOFAIL);
if (jh_in->b_frozen_data) {
jbd_slab_free(tmp, bh_in->b_size);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/