Re: [S390] hypfs sparse warnings.
From: Heiko Carstens
Date: Thu Sep 28 2006 - 10:23:06 EST
On Thu, Sep 28, 2006 at 03:54:06PM +0200, J?rn Engel wrote:
> On Thu, 28 September 2006 15:42:47 +0200, Heiko Carstens wrote:
> > On Thu, Sep 28, 2006 at 03:25:40PM +0200, J?rn Engel wrote:
> > > On Thu, 28 September 2006 15:07:37 +0200, Martin Schwidefsky wrote:
> > > >
> > > > sparse complains, if we use bitwise operations on enums. Cast enum to
> > > > long in order to fix that problem!
> > >
> > > At this point I start to wonder which part should be changed. Is it
> > > better to
> > > a) cast some more, as you started to do,
> > > b) change enums to #defines or
> > > c) change '|' to '+'?
> > >
> > > At any rate, you have the same problem in 5 seperate places by my
> > > count and only changed 1 of them. Nak - in case anyone cares.
> > That would be where? My sparse run didn't reveal anything else.
> Search for diag204. All calls have the same format with bitwise or of
> two enums, so they are all equally (in-)correct.
You probably need to update your git tree. All of them have casts in the
meantime. Except for the one addressed with this patch.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/