Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18

[Bernd Schmidt]

Arnd Bergmann wrote:

> static inline void local_irq_enable(void)
> {
> 	unsigned long unused_flags;
> 	asm volatile ("sti %0;" : : "d" (unused_flags));
> }
>
> That completely avoids all the problems you might hit with macro expansion,
> while still compiling to the same code.

The operand is an input, not an output.  We want to restore the proper 
mask of enabled interrupts with the STI.  That mask is in the global 
irq_flags variable (which probably ought to have a different name that 
doesn't invite clashes).


Bernd
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/