[PATCH] SCSI: shift device_reprobe() warning explosion

From: Jeff Garzik
Date: Wed Sep 27 2006 - 21:08:42 EST

SCSI warns about device_reprobe() for _every file_, even though there is
only a single caller in the entirety of SCSI.

The need to check return code is valid, so we update the warning area to
shift the burden to the [only] caller, mptsas.

Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx>

diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 895d212..b401c82 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -298,9 +298,9 @@ extern int scsi_execute_async(struct scs
void (*done)(void *, char *, int, int),
gfp_t gfp);

-static inline void scsi_device_reprobe(struct scsi_device *sdev)
+static inline int __must_check scsi_device_reprobe(struct scsi_device *sdev)
- device_reprobe(&sdev->sdev_gendev);
+ return device_reprobe(&sdev->sdev_gendev);

static inline unsigned int sdev_channel(struct scsi_device *sdev)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/