Re: [RFC] exponential update_wall_time

From: john stultz
Date: Wed Sep 27 2006 - 20:29:16 EST

On Thu, 2006-09-28 at 01:40 +0200, Roman Zippel wrote:
> Hi,
> On Wed, 27 Sep 2006, john stultz wrote:
> > > This is the wrong approach, second_overflow() should be called every HZ
> > > increment steps and your patch breaks this.
> >
> > First, forgive me, since I've got a bit of a head cold, so I'm even
> > slower then usual. I just don't see how this patch changes the behavior.
> > Every second we will call second_overflow. But in the case where we
> > skipped 100 ticks, we don't loop 100 times. Could you explain this a bit
> > more?
> second_overflow() changes the tick length, but the new tick length is now
> applied to varying number of ticks with your patch, which is bad for
> correct timekeeping.

Hmm.. Ok, I can see that. Thanks for the clarification.

> > > There are other approaches oo accommodate dyntick.
> > > 1. You could make HZ in ntp_update_frequency() dynamic and thus reduce the
> > > frequency with which update_wall_time() needs to be called (Note that
> > > other clock variables like cycle_interval have to be adjusted as well).
> >
> > I'm not sure how this is functionally different from what this patch
> > does.
> >
> >
> > > 2. If dynticks stops the timer interrupt for a long time, it could
> > > precalculate a few things, e.g. it could complete the second and then
> > > advance the time in full seconds.
> >
> > Not following this one at all.
> You have to keep in mind that ntp time is basically advanced in 1 second
> steps (or HZ ticks or freq cycles to be precise) and you have to keep that
> property. You can slice that second however you like, but it still has to
> add up to 1 second. Right now we slice it into HZ steps, but this can be
> rather easily changed now.

Right off, it seems it would then make sense to make the ntp "ticks" one
second in length. And set the interval values accordingly.

However, there might be clocksources that are incapable of running
freely for a full second w/o overflowing. In that case we would need to
set the interval values and the ntp tick length accordingly. It seems we
need some sort of interface to ntp to define that base tick length.
Would that be ok by you?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at