Re: [PATCH 2.6.19-rc1] ehea firmware interface based on Anton Blanchard'snew hvcall interface

From: Jeff Garzik
Date: Wed Sep 27 2006 - 17:52:59 EST

Jan-Bernd Themann wrote:
Hi Jeff,

the last patch did not work, so here is the new patch. The patch is build against
git:// HEAD today.
Could you give it a try?

Per the standard patch format in Documentation/SubmittingPatches, these sort of comments should go beneath the "---" separator. Otherwise, if they are not hand-edited out, they will go into the final changeset description.

This eHEA patch reflects changes according to Anton's new hvcall interface
which has been commited in Paul's git tree:


When is this going upstream? I don't want things to get too out-of-sync.

In addition to the above changes the patch includes a bug fix (port state
notification) and minor changes (default queue length, coding style updates).

These changes should be in a separate patch. Makes 'git bisect' work better, makes the changes more reviewable, and in general follows the "separate logical changes" rule.

diff -Nurp netdev-2.6/drivers/net/ehea/ehea_ethtool.c netdev-2.6_patched/drivers/net/ehea/ehea_ethtool.c
--- netdev-2.6/drivers/net/ehea/ehea_ethtool.c 2006-09-26 10:27:38.000000000 +0200
+++ netdev-2.6_patched/drivers/net/ehea/ehea_ethtool.c 2006-09-26 19:28:22.000000000 +0200
@@ -270,7 +270,7 @@ static void ehea_get_ethtool_stats(struc
-const struct ethtool_ops ehea_ethtool_ops = {
+struct ethtool_ops ehea_ethtool_ops = {
.get_settings = ehea_get_settings,
.get_drvinfo = ehea_get_drvinfo,
.get_msglevel = ehea_get_msglevel,

This is an obvious regression.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at