Re: [PATCH] libata-eh: Remove layering violation and duplicationwhen handling absent ports

From: Alan Cox
Date: Tue Sep 26 2006 - 15:04:54 EST

Ar Maw, 2006-09-26 am 13:35 -0400, ysgrifennodd Jeff Garzik:
> Alan Cox wrote:
> > This removes the layering violation where drivers have to fiddle
> > directly with EH flags. Instead we now recognize -ENOENT means "no port"
> > and do the handling in the core code.
> >
> > This also removes an instance of a call to disable the port, and an
> > identical printk from each driver doing this. Even better - future rule
> > changes will be in one place only.
> >
> > Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
> applied, but please stop adding trailing whitespace

I will have a further discussion with the source code of the joe editor.
I thought I'd fixed that.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at