Re: [PATCH 41/47] drivers/base: check errors

[Dmitry Torokhov]

On 9/26/06, Greg KH <greg@xxxxxxxxx> wrote:
> From: Andrew Morton <akpm@xxxxxxxx>
>
> Add lots of return-value checking.
>
> +               if (error)
> +                       goto out;
> +               error = sysfs_create_link(&bus->devices.kobj,
> +                                               &dev->kobj, dev->bus_id);
> +               if (error)
> +                       goto out;
> +               error = sysfs_create_link(&dev->kobj,
> +                               &dev->bus->subsys.kset.kobj, "subsystem");
> +               if (error)
> +                       goto out;
> +               error = sysfs_create_link(&dev->kobj,
> +                               &dev->bus->subsys.kset.kobj, "bus");
>        }
> +out:
>        return error;

What about removing the links that were created if one of these calls fails?

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/