Re: [PATCH 0/3] at91_serial: Introduction

[Haavard Skinnemoen]

On 26 Sep 2006 11:06:24 +0200
Andrew Victor <andrew@xxxxxxxxxxxxx> wrote:

> For patch 1, I'm not to keen on the:
> 
>   +#ifdef CONFIG_AVR32
>   +       port->flags |= UPF_IOREMAP;
>   +       port->membase = ioremap(pdev->resource[0].start,
>   +                               pdev->resource[0].end
>   +                               - pdev->resource[0].start + 1);
>   +#else
> 
> part.  It might be better to pass a flag (in the platform_data
> structure) whether we are providing a virtual or a physical address.
> (If you want early init on the serial console, then I recommend just
> using a static mapping for the DBGU peripheral).

I sent a new patch in the same thread with this instead:

+#ifdef CONFIG_AVR32
+	port->flags |= UPF_IOREMAP;
+	port->membase = NULL;
+#else

This means that the console will be initialized a bit late, but I can
live with that for now. Maybe we can agree on a platform_data format so
that we can remove the #ifdef altogether?

> Patch 2 & 3 look correct, but they would need to be tested.

Yeah, I'm struggling a bit with SPI right now, but I'll se if I can get
my AT91 board up and running after that.

I'll resend the first patch when the AVR32 patches are in, and the
last two after I've tested them on AT91.

Haavard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/