When will the lunacy end? (Was Re: [PATCH] uswsusp: addpmops->{prepare,enter,finish} support (aka "platform mode"))

[Nigel Cunningham]

Hi.

On Mon, 2006-09-25 at 09:13 +0200, Stefan Seyfried wrote:
> +	case SNAPSHOT_PMOPS:
> +		switch (arg) {
> +
> +		case PMOPS_PREPARE:
> +			if (pm_ops->prepare) {
> +				error = pm_ops->prepare(PM_SUSPEND_DISK);
> +			}
> +			break;
> +
> +		case PMOPS_ENTER:
> +			kernel_shutdown_prepare(SYSTEM_SUSPEND_DISK);
> +			error = pm_ops->enter(PM_SUSPEND_DISK);
> +			break;
> +
> +		case PMOPS_FINISH:
> +			if (pm_ops && pm_ops->finish) {
> +				pm_ops->finish(PM_SUSPEND_DISK);
> +			}
> +			break;
> +
> +		default:
> +			printk(KERN_ERR "SNAPSHOT_PMOPS: invalid argument %ld\n", arg);
> +			error = -EINVAL;
> +
> +		}
> +		break;
> +
>  	default:
>  		error = -ENOTTY;

Guys! Why can't you see yet that all this uswsusp business is sheer
lunacy? All of the important code is done in the kernel, and must be
done in the kernel. Moving the little bit of high level logic that can
be done in userspace to userspace doesn't mean you're doing the
suspending in userspace.

If you have to use userspace for suspending, use it for the things that
don't matter, like the user interface, not the things that will break
suspending and resuming if they break.

</rant>

Nigel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/