Re: [PATCH] restore libata build on frv

From: Alan Cox
Date: Mon Sep 25 2006 - 11:22:43 EST


Ar Llu, 2006-09-25 am 15:39 +0100, ysgrifennodd David Howells:
> Why does the arch have to supply those numbers? What's wrong with my
> suggested patch? According to code in libata, these are _legacy_ access
> methods, and on FRV they aren't currently required, so why can't I dispense

"legacy, legacy, legacy" "wont wont wont"

The ports in question are PCI values. They come from the PCI
specifications and apply to any device with PCI bus, unless it has
special mappings. The same logic you are whining about is already partly
handled in the generic pci quirks code, and in time will end up with the
I/O port value fixups there anyway.

See quirk_ide_bases in drivers/pci/quirks.c

Go read the specifications and stop whining about legacy ports and ISA
bus for things that are not.

Ack Al Viro's changes but with IRQ set to zero.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/