Re: [PATCH] libata: rework legacy handling to remove much of thecruft

From: David Woodhouse
Date: Mon Sep 25 2006 - 06:15:46 EST

On Sun, 2006-09-24 at 18:05 +0000, Linux Kernel Mailing List wrote:
> +#define ATA_PRIMARY_CMD 0x1F0
> +#define ATA_PRIMARY_CTL 0x3F6
> +#define ATA_PRIMARY_IRQ 14
> +
> +#define ATA_SECONDARY_CMD 0x170
> +#define ATA_SECONDARY_CTL 0x376
> +#define ATA_SECONDARY_IRQ 15

Please, don't do this. We've only just cleaned up the serial driver to
get rid of crap like this -- we _don't_ want to do it like this.

We should register the non-discoverable devices as platform devices (or
of_devices, or something), and not just hardcode stuff like this in
asm/foo.h headers.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at