[PATCH] wrong thing iounmapped (qla3xxx)

From: Al Viro
Date: Sun Sep 24 2006 - 21:55:17 EST

ql3xxx_probe() does ioremap and stores result in
->mem_map_registers. On failure exit it does iounmap()
of the same thing. OTOH, ql3xxx_remove() does iounmap()
of ->mmap_virt_base which is (a) never assigned and
(b) never used other than in that iounmap() call.

Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
drivers/net/qla3xxx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index c184cd8..1574718 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -3508,7 +3508,7 @@ static void __devexit ql3xxx_remove(stru
qdev->workqueue = NULL;

- iounmap(qdev->mmap_virt_base);
+ iounmap(qdev->mem_map_registers);
pci_set_drvdata(pdev, NULL);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/