Re: NV SATA breakage: jgarzik/libata-dev#upstream etc

From: Jeff Garzik
Date: Sun Sep 24 2006 - 20:26:44 EST

Krzysztof Halasa wrote:

The following commit in libata-dev breaks NV SATA init - I don't
have a dump handy, but the problem is a NULL ptr dereference here:

int ata_device_add(const struct ata_probe_ent *ent)
/* register each port bound to this device */
for (i = 0; i < host->n_ports; i++) {
/* start port */
rc = ap->ops->port_start(ap);

The problematic commit is fea63e38013ec628ab3f7fddc4c2148064b7910a:
"[PATCH] libata: fix non-uniform ports handling

Non-uniform ports handling got broken while updating libata to handle
those in the same host. Only separate irq for the non-uniform
secondary port was implemented while all other fields (host flags,
transfer mode...) of the secondary port simply shared those of the

What's broken, and how does it affect NV sata?

That's the chipset on my main dev workstation, and there are no problems here...


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at