[Patch] Remove unnecessary check indrivers/pci/hotplug/pciehp_ctrl.c

From: Eric Sesterhenn
Date: Sun Sep 24 2006 - 18:57:15 EST


hi,

this was spotted by coverity (cid #819). We dereference p_slot
earlier in the function, and i found no way it could become NULL
anywhere.

Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>

--- linux-2.6.18-git3/drivers/pci/hotplug/pciehp_ctrl.c.orig 2006-09-24 22:19:11.000000000 +0200
+++ linux-2.6.18-git3/drivers/pci/hotplug/pciehp_ctrl.c 2006-09-24 22:25:10.000000000 +0200
@@ -790,8 +790,7 @@ int pciehp_enable_slot(struct slot *p_sl
p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
}

- if (p_slot)
- update_slot_info(p_slot);
+ update_slot_info(p_slot);

return rc;
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/