Re: [GIT] Linux client patches against Linux 2.6.18

From: Trond Myklebust
Date: Sun Sep 24 2006 - 02:39:19 EST

On Sat, 2006-09-23 at 17:06 -0700, Linus Torvalds wrote:

> I'm not seeing a sign-off or ack for the dentry stuff from Al, for
> example. Was it passed by him? You moved the dentry rehash function inside
> the dcache_lock, and if that was a bug-fix, it should have been marked as
> so and done separately etc.

The only function that was moved inside the spinlock was d_hash(), but
that is a fairly trivial change (d_revalidate already does the same).
Otherwise, the only effect of the changes was to create unlocked
versions of d_rehash() for reuse in the new d_materialise_dentry().

In any case, all of those patches have been presented by David on the
fs-devel and lkml lists several times. The last time would be on 27th

Al has in addition been Cced on much of the correspondence between David
and myself during the preparation for merging (although that would be
almost half a year ago now).
Finally, Christoph was also pressed into duty as an extra reviewer.

So yes, afaik all the relevant people have been kept informed, even if
they were not labelled as having been Cced in the changelog.

So I apologize for not having sent this as a separate patch, but as I
said above, it was a trivial change as far as the rehash is concerned,
and the only user of the new function is NFS.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at