Re: [GIT] Linux client patches against Linux 2.6.18

From: Linus Torvalds
Date: Sat Sep 23 2006 - 20:07:04 EST




On Fri, 22 Sep 2006, Trond Myklebust wrote:
>
> git pull git://git.linux-nfs.org/pub/linux/nfs-2.6.git

I'm not entirely happy with this.

Why were the generic VFS layer patches wrapped up in this big thing,
instead of being sent separately with the proper people looking at them?

I'm not seeing a sign-off or ack for the dentry stuff from Al, for
example. Was it passed by him? You moved the dentry rehash function inside
the dcache_lock, and if that was a bug-fix, it should have been marked as
so and done separately etc.

In other words, this was _not_ the right way to merge these things. I'm a
bit grumpy.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/