Re: [PATCH]: Fix ALIGN() macro

From: David Miller
Date: Sat Sep 23 2006 - 16:13:48 EST


From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 24 Sep 2006 00:40:41 +1000

> OK I think I've found the problem.
>
> [CRYPTO] hmac: Fix hmac_init update call
>
> The crypto_hash_update call in hmac_init gave the number 1
> instead of the length of the sg list in bytes. This is a
> missed conversion from the digest => hash change.
>
> As tcrypt only tests crypto_hash_digest it didn't catch this.
>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

This, along with the ALIGN() patch, fixes all the regressions
for me. Good spotting Herbert!

Linus, please apply.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/