Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source

From: Alexey Dobriyan
Date: Thu Sep 21 2006 - 01:16:14 EST


On Wed, Sep 20, 2006 at 12:36:52PM -0400, Dave Jones wrote:
> On Wed, Sep 20, 2006 at 09:28:05AM +0300, Pekka Enberg wrote:
> > On 9/20/06, Andrew Morton <akpm@xxxxxxxx> wrote:
> > > Trivia:
> >
> > [snip]
> >
> > More trivia:
> >
> > - Unnecessary casts for void pointers
> > - Assignment in if statement expression
>
> also
>
> +#include <linux/config.h>
> +#include <linux/module.h>
> +#include <linux/kernel.h>
>
> Some unnecessary includes there. (config.h & kernel.h are auto-included)

Only config.h (technically, autoconf.h)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/