Re: drivers/char/random.c exported interfaces

From: Dmitry Torokhov
Date: Thu Sep 21 2006 - 00:11:44 EST


On Wednesday 20 September 2006 13:04, Robin Getz wrote:
> Randy Dunlap said:
> >ISTM that we should at least fix the first 2 (by EXPORTing them).
> >or we don't allow INPUT=m.
> >
> >You want to send a patch?
>
> No problem - which patch do you want? (exporting? or set INPUT to bool?)
>
> I'll send the export later tonight if no objections.
>

Would there be any objections if I commit the patch below so input
could be built as a module?

--
Dmitry

Input: fix building input core as a module

Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
---

drivers/char/random.c | 1 +
lib/kobject.c | 1 +
2 files changed, 2 insertions(+)

Index: work/drivers/char/random.c
===================================================================
--- work.orig/drivers/char/random.c
+++ work/drivers/char/random.c
@@ -645,6 +645,7 @@ void add_input_randomness(unsigned int t
add_timer_randomness(&input_timer_state,
(type << 4) ^ code ^ (code >> 4) ^ value);
}
+EXPORT_SYMBOL_GPL(add_input_randomness);

void add_interrupt_randomness(int irq)
{
Index: work/lib/kobject.c
===================================================================
--- work.orig/lib/kobject.c
+++ work/lib/kobject.c
@@ -119,6 +119,7 @@ char *kobject_get_path(struct kobject *k

return path;
}
+EXPORT_SYMBOL_GPL(kobject_get_path);

/**
* kobject_init - initialize object.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/