[PATCH] slim: handle failure to register

From: Kylene Jo Hall
Date: Wed Sep 20 2006 - 12:49:30 EST


Thanks to Stephen Smalley for pointing out that we need to securely
handle a failure to register with the LSM security hooks. This patch
adds a panic in the event that the module is unable to register.

Signed-off-by: Kylene Hall <kjhall@xxxxxxxxxx>
Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxx>
---
security/slim/slm_main.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
--- linux-2.6.18-rc6-orig/security/slim/slm_main.c 2006-09-18 16:41:51.000000000 -0500
+++ linux-2.6.18-rc6/security/slim/slm_main.c 2006-09-19 12:48:42.000000000 -0500
@@ -1644,9 +1644,13 @@ int slim_enabled = 1;
#endif
static int __init init_slm(void)
{
+ int rc;
if (!slim_enabled)
return 0;
slm_task_init_alloc_security(current);
- return register_security(&slm_security_ops);
+ rc = register_security(&slm_security_ops);
+ if (rc != 0)
+ panic("SLIM: Unable to register with kernel\n");
+ return rc;
}
security_initcall(init_slm);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/