Re: [PATCH] piix: Use refcounted interface when searching for a450NX

From: Andrew Morton
Date: Fri Sep 15 2006 - 12:54:42 EST


On Fri, 15 Sep 2006 15:14:38 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> Simple conversion
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc6-mm1/drivers/ide/pci/piix.c linux-2.6.18-rc6-mm1/drivers/ide/pci/piix.c
> --- linux.vanilla-2.6.18-rc6-mm1/drivers/ide/pci/piix.c 2006-09-11 17:00:09.000000000 +0100
> +++ linux-2.6.18-rc6-mm1/drivers/ide/pci/piix.c 2006-09-14 17:19:12.000000000 +0100
> @@ -602,7 +602,7 @@
> struct pci_dev *pdev = NULL;
> u16 cfg;
> u8 rev;
> - while((pdev=pci_find_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
> + while((pdev=pci_get_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
> {
> /* Look for 450NX PXB. Check for problem configurations
> A PCI quirk checks bit 6 already */

fwiw, I have an ad450nx server upon which I occasionally test kernels.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/