Re: [PATCH] mpparse.c:231: warning: comparison is always false

From: Dave Jones
Date: Fri Sep 15 2006 - 11:24:30 EST


On Fri, Sep 15, 2006 at 01:23:02AM -0700, Andrew Morton wrote:

> > > Thanks. Andi has already queued a similar patch.
> > >
> > > Andi, you might as well scoot that upstream, otherwise we'll get lots of
> > > emails about it.
> > ...
> > > > +#if 0xFF >= MAX_MP_BUSSES
> > > > if (m->mpc_busid >= MAX_MP_BUSSES) {
> > I don't know how Andi has fixed it,
> Same thing. (He has `#if MAX_MP_BUSSES < 256').

How can this be the right the right thing to do ?
It should *never* be >=256. mach-summit/mach-generic need fixing
to be 255, not this ridiculous band-aid. Where did 260 come from anyway?

Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/