Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]

From: David Howells
Date: Fri Sep 15 2006 - 10:43:43 EST


Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> Except the get_order() interface is purely related to pages (the fact
> that you have reimplemented it using the log2-based functions is just an
> implementation detail.

Do you have a major objection to it moving to linux/log2.h (do you count the
one you've just raised as "major")?

I'd rather avoid including linux/log2.h or linux/kernel.h in asm/page.h, plus
asm-generic/page.h isn't used by all archs (though that's a minor point).

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/