Re: [PATCH] raw: return negative from raw_init()

[Andrew Morton]

On Tue, 12 Sep 2006 05:19:18 +0400
Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> ---
> 
>  drivers/char/raw.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/char/raw.c
> +++ b/drivers/char/raw.c
> @@ -312,7 +312,7 @@ static int __init raw_init(void)
>  
>  error:
>  	printk(KERN_ERR "error register raw device\n");
> -	return 1;
> +	return -1;
>  }
>  
>  static void __exit raw_exit(void)

Rolf got there first.  Please review
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm2/broken-out/return-better-error-codes-if-drivers-char-rawc-module-init-fails.patch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/