Re: [PATCH] linux/magic.h for magic numbers

[Jeff Garzik]

Ian Kent wrote:
> On Sat, 9 Sep 2006, Jeff Garzik wrote:
>
> > An IRC discussion sparked a memory:  most filesystems really don't
> > need to put anything at all in include/linux.  Excluding API-ish
> > filesystems like procfs, just about the only filesystem symbols that
> > get exported outside of __KERNEL__ are the *_SUPER_MAGIC symbols,
> > and similar symbols.
> >
> > After seeing the useful attributes of linux/poison.h, I propose a
> > similar linux/magic.h.
> >
> > We can see from the patch below that this permitted the deletion of a
> > couple headers, where the *_SUPER_MAGIC symbol was the only thing in the
> > entire header.
> >
> > Other non-filesystem-related magic numbers could get moved here
> > eventually, if maintainers so desire, but I wanted to start off with the
> > obvious low-hanging fruit.
>
> Would be good to include autofs in this lot.
>
> Defined in linux/autofs/autofs_i.h
> Defined in linux/autofs4/autofs_i.h
>
> as 
>
> #define AUTOFS_SUPER_MAGIC 0x0187

Updated.

Andrew, please add the "magic" branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git

to the list of trees you pull.

Thanks,

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/