Re: Split multi-line printk in oops output.

[Andi Kleen]

On Monday 11 September 2006 08:07, Dave Jones wrote:
> On Mon, Sep 11, 2006 at 07:44:15AM +0200, Andi Kleen wrote:
>  > >  	print_modules();
>  > > -	printk(KERN_EMERG "CPU:    %d\nEIP:    %04x:[<%08lx>]    %s VLI\n"
>  > > -			"EFLAGS: %08lx   (%s %.*s) \n",
>  > > -		smp_processor_id(), 0xffff & regs->xcs, regs->eip,
>  > > -		print_tainted(), regs->eflags, system_utsname.release,
>  > > +	printk(KERN_EMERG "CPU:    %d\n", smp_processor_id());
>  > > +	printk(KERN_EMERG "EIP:    %04x:[<%08lx>]    %s VLI\n",
>  > > +		0xffff & regs->xcs, regs->eip, print_tainted());
>  > > +	printk(KERN_EMERG "EFLAGS: %08lx   (%s %.*s)\n",
>  >
>  > Still only using a single printk would be slightly safer
>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>

Added thanks., Please include the full description on reposted patches
in the future too.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/