Re: [PATCH] linux/magic.h for magic numbers

[Jeff Garzik]

Grzegorz Kulewski wrote:
> On Sat, 9 Sep 2006, Jeff Garzik wrote:
> > An IRC discussion sparked a memory:  most filesystems really don't
> > need to put anything at all in include/linux.  Excluding API-ish
> > filesystems like procfs, just about the only filesystem symbols that
> > get exported outside of __KERNEL__ are the *_SUPER_MAGIC symbols,
> > and similar symbols.
> >
> > After seeing the useful attributes of linux/poison.h, I propose a
> > similar linux/magic.h.
>
> But... if some patch changes this file (like adding new magic symbol) it 
> will cause large part of the kernel to rebuild without any good reason. No?

No :)

* The days when linux/fs.h included individual filesystem headers is 
long gone.  Only the filesystems themselves typically include the 
linux/foo_fs*.h files these days.

* It's not like we add new filesystems to the kernel very often.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/