[patch -mm] s390: fix save_stack_trace

From: Heiko Carstens
Date: Fri Sep 08 2006 - 08:19:51 EST


From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>

x86_64-mm-stacktrace-cleanup.patch reverses the logic in s390's
save_stack_trace incorrectly. Fix this.

Cc: Andi Kleen <ak@xxxxxxx>
Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
---

arch/s390/kernel/stacktrace.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.17/arch/s390/kernel/stacktrace.c
===================================================================
--- linux-2.6.17.orig/arch/s390/kernel/stacktrace.c 2006-09-08 13:44:44.000000000 +0200
+++ linux-2.6.17/arch/s390/kernel/stacktrace.c 2006-09-08 14:00:36.000000000 +0200
@@ -70,12 +70,12 @@
sp = save_context_stack(trace, &trace->skip, sp,
S390_lowcore.panic_stack - PAGE_SIZE,
S390_lowcore.panic_stack);
- if ((sp != orig_sp) && trace->all_contexts)
+ if ((sp != orig_sp) && !trace->all_contexts)
return;
sp = save_context_stack(trace, &trace->skip, sp,
S390_lowcore.async_stack - ASYNC_SIZE,
S390_lowcore.async_stack);
- if ((sp != orig_sp) && trace->all_contexts)
+ if ((sp != orig_sp) && !trace->all_contexts)
return;
if (task)
save_context_stack(trace, &trace->skip, sp,
@@ -85,5 +85,4 @@
save_context_stack(trace, &trace->skip, sp,
S390_lowcore.thread_info,
S390_lowcore.thread_info + THREAD_SIZE);
- return;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/