Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement

[Nathan Scott]

On Fri, Sep 01, 2006 at 01:52:51AM +0200, Richard Knutsson wrote:
> From: Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx>
> 
> Converting error-prone statement:
> "if (var == B_FALSE)" into "if (!var)"
> "if (var == B_TRUE)"  into "if (var)"

This is my preference too, rather than the local boolean usage which
isn't used with any consistency... but:

> Compile-tested

Are you using XFS on your systems?  What is your strategy for getting this
runtime tested going to be?  Or are you delegating that responsibility? :)

cheers.

-- 
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/