[Patch] Uninitialized variable in drivers/scsi/ncr53c8xx.c

From: Eric Sesterhenn
Date: Thu Aug 31 2006 - 19:26:38 EST


hi,

this was spotted by coverity (id #880).
We use simple_strtoul() earlier to initialize pe,
if the function fails, it also does not initialize it.
Therefore we should initialize it ourselves, so the check
in the OPT_TAGS case "if (pe && *pe == '/')" makes sense, and
actually makes the command line parsing more robust.

Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>

--- linux-2.6.18-rc5/drivers/scsi/ncr53c8xx.c.orig 2006-09-01 01:25:09.000000000 +0200
+++ linux-2.6.18-rc5/drivers/scsi/ncr53c8xx.c 2006-09-01 01:25:26.000000000 +0200
@@ -692,7 +692,7 @@ static int __init sym53c8xx__setup(char
int xi = 0;

while (cur != NULL && (pc = strchr(cur, ':')) != NULL) {
- char *pe;
+ char *pe = NULL;

val = 0;
pv = pc;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/