Re: [PATCH][RFC] exception processing in early boot

From: Andi Kleen
Date: Wed Aug 30 2006 - 05:48:48 EST


Willy Tarreau <w@xxxxxx> writes:

> Hi,
>
> PaX Team has sent me this patch for inclusion. Basically, during early
> boot on x86, the exception handler does not make a special case for
> exceptions which push an error code onto the stack, leading to a return
> to a wrong address. Two patches were proposed, one which would add a
> special case for all exceptions using the return code, and this one. The
> former was of no use in its form because the return from the exception
> handler would get back to the faulting exception, causing it to loop.
>
> This one should be better as it effectively hangs the system using HLT
> to prevent CPU from burning.

Looks good.

[I'm glad this particular ward in x86 was fixed in x86-64 ...]

>
> If nobody has any objections, I will merge it. In this case, I would also
> like someone to check if 2.6 needs it and to port it in this case.

I don't think you should merge anything like this before 2.6 does. Otherwise
we just end up with the mad situation again that an old release has
more bugs fixed or more features than the new release.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/