Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]

From: Mattia Dongili
Date: Tue Aug 29 2006 - 02:38:14 EST


On Mon, August 28, 2006 11:30 pm, Andrew Morton said:
> On Mon, 28 Aug 2006 22:07:16 +0200
> Mattia Dongili <malattia@xxxxxxxx> wrote:
[...]
>> it's at fib6_rules.c:132 but since I can't tell why r->fwmask is 0 I'll
>> avoid proposing a wrong patch :)
>
> Oh. It looks like this has already been fixed:
>
> #ifdef CONFIG_IPV6_ROUTE_FWMARK
> if ((r->fwmark ^ fl->fl6_fwmark) & r->fwmask)
> return 0;
> #endif
>
> there's no divide in there now.

Ok, great, I have a division instead of the bitwise and there in fact.

thanks
--
mattia
:wq!


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/