Re: Reiser4 und LZO compression

[Edward Shishkin]

Jindrich Makovicka wrote:
> On Sun, 27 Aug 2006 04:42:59 -0500
> David Masover <ninja@xxxxxxxxxxxx> wrote:
>
>
> > Andrew Morton wrote:
> >
> > > On Sun, 27 Aug 2006 04:34:26 +0400
> > > Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> > >
> > >
> > > > The patch below is so-called reiser4 LZO compression plugin as
> > > > extracted from 2.6.18-rc4-mm3.
> > > >
> > > > I think it is an unauditable piece of shit and thus should not
> > > > enter mainline.
> > >
> > > Like lib/inflate.c (and this new code should arguably be in lib/).
> > >
> > > The problem is that if we clean this up, we've diverged very much
> > > from the upstream implementation.  So taking in fixes and features
> > > from upstream becomes harder and more error-prone.
> >
> > Well, what kinds of changes have to happen?  I doubt upstream would
> > care about moving some of it to lib/ -- and anyway, reiserfs-list is
> > on the CC.  We are speaking of upstream in the third party in the
> > presence of upstream, so...
>
>
> The ifdef jungle is ugly, and especially the WIN / 16-bit DOS stuff is
> completely useless here.

I agree that it needs some brushing,
putting in todo..


> > Maybe just ask upstream?
>
>
> I am not sure if Mr. Oberhumer still cares about LZO 1.x, AFAIK he now
> develops a new compressor under a commercial license.
>
> Regards,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/