Re: printk()s of user-supplied strings

[Valdis . Kletnieks]

On Mon, 28 Aug 2006 05:52:24 +0400, Solar Designer said:

> > Serial driver version 5.05c (2001-07-08) with MANY_PORTS SHARE_IRQ SERIAL_P
CI ISAPNP enabled^J<6>ttyS00 at 0x03f8 (irq = 4) is a 16550A
> 
> The first line (before the ^J) is output with:
> 
> 	printk(KERN_INFO "%s version %s%s (%s) with%s", serial_name,
> 	       serial_version, LOCAL_VERSTRING, serial_revdate,
> 	       serial_options);
> 
> The linefeed is embedded in serial_options.

Gaak.  And I suppose that in *addition* to having an embedded trailing \n,
it *also* has a leading blank to make 'with%s' work correctly?

Fortunately, find . | xargs grep 'serial_revdate' comes up empty on
a 2.6.18-rc4-mm3 tree, so somebody's swatted this blecherousness already.

Attachment: pgp00000.pgp
Description: PGP signature