Re: another NUMA build error

[Randy.Dunlap]

> > 
> Hmm... is this the way to go ?
> Keith-san, please ack if Okay.

Works for me.  No build errors.  Thanks.
There are a couple of typos noted below that could be fixed up.

> --
> When we select NUMA with i386, the system is only X86_NUMAQ or using ACPI.
> 
> Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> 
> Index: linux-2.6.18-rc4/arch/i386/Kconfig
> ===================================================================
> --- linux-2.6.18-rc4.orig/arch/i386/Kconfig
> +++ linux-2.6.18-rc4/arch/i386/Kconfig
> @@ -142,6 +142,7 @@ config X86_SUMMIT
>  	  In particular, it is needed for the x440.
>  
>  	  If you don't have one of these computers, you should say N here.
> +	  If you want to build NUMA kernel, you have to select ACPI

		end with '.'

>  
>  config X86_BIGSMP
>  	bool "Support for other sub-arch SMP systems with more than 8 CPUs"
> @@ -169,6 +170,7 @@ config X86_GENERICARCH
>         help
>            This option compiles in the Summit, bigsmp, ES7000, default subarchitectures.
>  	  It is intended for a generic binary kernel.
> +	  if you want NUMA kernel, select ACPI. we need SRAT for build NUMA

	  If you want a NUMA kernel, enable ACPI. We need SRAT to build NUMA.

>  
>  config X86_ES7000
>  	bool "Support for Unisys ES7000 IA32 series"
> @@ -542,7 +544,7 @@ config X86_PAE
>  # Common NUMA Features
>  config NUMA
>  	bool "Numa Memory Allocation and Scheduler Support"
> -	depends on SMP && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || (X86_SUMMIT && ACPI))
> +	depends on SMP && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI)
>  	default n if X86_PC
>  	default y if (X86_NUMAQ || X86_SUMMIT)


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/