Re: [PATCH 4/4] eCryptfs: ino_t to u64 for filldir

From: David Howells
Date: Fri Aug 25 2006 - 17:48:37 EST


Michael Halcrow <mhalcrow@xxxxxxxxxx> wrote:

> filldir()'s inode number is now type u64 instead of ino_t.

Btw, in ecryptfs_interpose(), you have:

inode = iget(sb, lower_inode->i_ino);

But you have to be *very* *very* careful doing that. i_ino may be ambiguous.
My suggestions to make i_ino bigger were turned down by Al Viro; and even it
were bigger, it might still not be unique.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/